Remove duplicate Query by Example collection-property note#4270
Closed
jewoodev wants to merge 1 commit into
Closed
Remove duplicate Query by Example collection-property note#4270jewoodev wants to merge 1 commit into
jewoodev wants to merge 1 commit into
Conversation
The JPA module sets `:support-qbe-collection: false` at the top of `query-by-example.adoc`, which enables the "No support for matching collections or maps." bullet in the limitations list rendered from the Spring Data Commons page. The standalone JPA-specific NOTE placed right after the repository usage example duplicates that limitation in less accessible wording (the JPA metamodel term `SingularAttribute`) and at an unrelated location. Drop it so the limitation is communicated once, in the limitations section, with end-user terminology. Closes spring-projects#1472 Signed-off-by: jewoodev <jewoos15@naver.com>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: documentation
Member
|
Thank you for your contribution. That's merged and backported now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spring Data JPA already renders the shared Query by Example limitations section with
:support-qbe-collection: false, which includes "No support for matching collections or maps."This removes the JPA-specific
SingularAttributeNOTE because it describes the same limitation in a duplicate location and with less user-facing terminology. Runtime behavior matches the shared wording:QueryByExamplePredicateBuilderiterates overtype.getSingularAttributes(), so plural attributes are not matched.No production code changes.
Closes #1472